This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Change the Stackdriver exporters' Register() to return Status.#240
Open
g-easy wants to merge 2 commits intocensus-instrumentation:masterfrom
Open
Change the Stackdriver exporters' Register() to return Status.#240g-easy wants to merge 2 commits intocensus-instrumentation:masterfrom
g-easy wants to merge 2 commits intocensus-instrumentation:masterfrom
Conversation
Make this non-breaking change to the API now, so we can use it to implement census-instrumentation#175 later.
Contributor
Author
|
I think these functions should return The other kind of Status we have in OpenCensus is for describing the status of a span in our own data model, which I don't think is appropriate here. Abseil may one day release its own Status type, but that hasn't happened yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make this non-breaking change to the API now, so we can use it
to implement #175
later.